Add exports to package.json to satisfy nodejs --experimental-module u… #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we can create a package.json in the es5m dir that only has |
…sers Fixes insidewhy#206 This ensures that consumers using --experimental-modules with node 12+ will import the esm version of this package. This package's export must a package.json with "type": "json" (or module files must have .mjs extension)... This package's export must also use exports field in the package.json because node doesn't support the "module" field as an alternative to "main". see https://nodejs.org/api/packages.html#conditional-exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sers
Fixes #206
This ensures that consumers using --experimental-modules with node 12+
will import the esm version of this package.
This package's export MUST have .mjs file extension... (because
otherwise the entire package must be specified as type: module)
This package's export MUST use exports field in the package.json
see https://nodejs.org/api/packages.html#conditional-exports
Not sure how to test this with a bunch of different project styles..
webpack and other loaders should be fine with importing from the
modulefield with a.mjsfile extension?